-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement global blocklist #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to reduce the amount of time that I need to figure out how to do this, and as Modmail does this already (for example, https://github.com/modmail-dev/Modmail/blob/master/core/time.py#L177C1-L281C22), it's just fine to rip it off
…/rodhaj into noelle/blacklist
In favor of a custom time converter based off of R. Danny's but is made to use with arrow
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR focuses to implement a global blocklist. When an user is blocked by the bot, all tickets and access to the bot is nullified. For prefixed commands/messages, no response will go to the ticket and no response from commands will be sent back. For app commands, an ephemeral message is sent denoting that the user is blocked. Mods can either manually remove users from the blocklist manually or have it automatically removed after an desired amount of days. Hierarchy and permissions are factored into this process.
For simplicity and practicality purposes, the blocklist will only accept members, not roles. Modmail accepts both, but in the context of the transprogrammer server, it's too risky allowing roles to be blocked and each user isn't tied to an specific role. As the server has roles for a wide variety of labels, blocking one role just because of one user is in that role makes no sense.
Before this PR can be merged, a wide variety of tasks need to be completed. These are noted as the following:
EntityConverter
config blocklist remove
Note: The timer and all other improvement features are slated to be implemented in another PR. This PR solely aims to provide the base implementation of the global blocklist system
Types of changes
What types of changes does your code introduce to Rodhaj
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply